Re: [PATCH 9/9] Detect window-system from display name

[Eli Zaretskii]

> Date: Tue, 07 Aug 2012 01:19:27 -0700
> From: Daniel Colascione <address@hidden>
> 
> +(add-to-list 'display-format-alist '("\\`windows\\'" . w32))

Is this kind of addition needed only for make-frame-on-display, or is
it used for other functions as well?

> +  CHECK_STRING (display);
> +  if (strcmp (SSDATA (display), "windows"))
> +    error ("The name of the Windows display must be \"windows\"");

Why signal an error here?

In any case, please use 'strcmp (...) != 0' here.

I think the bulk of this changeset should be reviewed by someone else,
as it has very little to do with Windows.