Re: [PATCH 1/2] Merge subword-mode and capitalized-words-mode

[Masatake YAMATO]

> subword-mode began life as part of cc-mode, but because it's
> generally useful, it was extracted and made a generic part of
> Emacs.  subword-mode uses command remapping to achive its subword
> motion, however, and this mechanism can't catch all kinds of word-
> based motion, resulting in inconsistency.
> 
> capitalized-words-mode attempts to do what subword-mode does, but
> using a hook added to C core for the purpose.  This hook allows
> capitalizd-words-mode to change all kinds of word-based motion
> into subword motion.  Unfortunately, capitalized-words-mode used
> overly simplistic code that caused it to fail to properly move
> over words like "fooBarBAZ"; subword-mode handles these words
> properly.  capitalized-words-mode is also disadvantaged by
> a long and misleading name.
> 
> This patch merges subword-mode and capitalized-words-mode by
> modifying subword-mode to use the core hook and marking
> capitalized-words-mode as an obsolete alias for subword-mode.
> 
> This patch also includes an automated test for subword motion.

Nice.

> -;; TODO: ispell-word.
> -

Does this mean subword-mode can handle ispell with your patch?
If yes, it is really nice.
If not, please keep the TODO item in the comment of the file.

> diff --git a/test/automated/subword.el b/test/automated/subword.el
> new file mode 100644
> index 0000000..9e769cf
> --- /dev/null
> +++ b/test/automated/subword.el
> @@ -0,0 +1,58 @@
> +;;; vc-bzr.el --- tests for progmodes/subword.el

This should be subword.el, shouldn't be?
 
Masatake YAMATO