[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] response handlers needed for SASL PLAIN authentication
|
From: |
Glenn Morris |
|
Subject: |
Re: [PATCH 2/2] response handlers needed for SASL PLAIN authentication |
|
Date: |
Thu, 19 Apr 2012 13:01:37 -0400 |
|
User-agent: |
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) |
Joseph Gay wrote:
> +;; Copyright (C) 2012 Free Software Foundation, Inc.
Please don't write this unless you have completed a copyright
assignment. Just use your name.
> +;; This file is part of GNU Emacs.
Again, not true yet.
> +(defvar erc-sasl-use-sasl t
> + "Set to nil to disable SASL auth")
> +
> +(defvar erc-sasl-server-regexp-list '()
> + "List of regexps matching server host names for which sasl
> + should be used")
These should be defcustoms. Also, the first line of any doc string
should be a complete sentence, with a full-stop at the end.