Re: [PATCH] Change the look of dialogs created with `x-popup-dialog'

[Jan D.]

Andrey Smirnov skrev 2011-12-15 05:56:
> On Wed, Dec 14, 2011 at 12:41 PM, Jan Djärv<address@hidden>  wrote:
> > If you Alt-tab in icewm for example, it shows the titles, see
> > attached picture.
>
> Now, I see your point. On the other hand in Unity window title doesn't
> play that important role in window-switching. Can we compromise on
> exposing run-time variable something along the lines of
> `gtk-popup-dialogs-show-titles' and then the appearance could be
> controlled from user's .emacs?

I think we should keep the same title as we had before.  Those that need 
it really need it, and those that don't won't notice it.

> All right, in for a penny in for a pound, how about
> `gtk-popup-dialogs-message-format' to control that aspect?

I'm not opposed to using larger and bold, but I think we need some sort 
of poll, or a descision from the maintainers.

> > Perhaps, but then we maybe should change all ports?
>
> Do you mean change how dialogs look in all toolkits?

Actually I was just talking about larger and bold here.

> It still won't change the fact that original
> `dialog_selection_callback' duplicates the functionality of
> `popup_deactivate_callback'.

Yes, but that is something we won't want to change, as some toolkits 
can't chain callbacks as Gtk+ can.  And it forces changes for other 
toolkits as well, for a small gain in clarity.

> I attached reworked version of the patch, it still lacks comments with
> description for new functions, but I'll add it as soon as the code
> stabilizes.

You are still not resetting popup_activated_flag.

+struct xg_popup_dialog_callback_data
+{
+  void (*select_cb) (GtkWidget *, gpointer);
+  void (*deactivate_cb) (GtkWidget *, gpointer);
+  gboolean multichoice_p;
+  GSList *radio_buttons;
+};
+

You could use GCallback here and cast functions with GCALLBACK().  It is 
more Gtk-ish.  Otherwise, make a typedef like:
  typedef void (*Xg_CBfunction) (GtkWidget *, gpointer);
and use Xg_CBfunction.


+      struct xg_popup_dialog_callback_data *data = g_malloc (sizeof 
(*data));

This is never free:d.

        Jan D.