Re: /srv/bzr/emacs/trunk r104665: Rewritten smtpmail.el to use `open-network-stream' to do STARTTLS

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <address@hidden> writes:

>> +      (setq result
>> +            (open-network-stream
>> +             "smtpmail" process-buffer host port
>> +             :type smtpmail-stream-type
>> +             :return-list t
>
> I've been using smtpmail with replacing `open-network-stream' with
> `my-open-network-stream'.

You had defaliased `open-network-stream' to `my-open-network-stream'?
In that case, wouldn't calling `my-open-network-stream' break here, too,
since the caller now supplies all those extra keywork parameters that
weren't present in the old `open-network-stream'?

Anyway, I think your patch is otherwise fine, but I'm not sure how
needed it is.  I mean, anybody who's aliased `open-network-stream' could
be expected to fix the calling sequence and return values.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/