Re: System calls without error checks in w32

[Lennart Borgman]

On Mon, May 31, 2010 at 4:02 AM, Juanma Barranquero <address@hidden> wrote:
> On Mon, May 31, 2010 at 02:58, Lennart Borgman
> <address@hidden> wrote:
>
>> I don't think so. It is just much more difficult to track some of
>> these. For example I know Drew recently wrote about problems when
>> creating new frames. It is quite hard to both understand what is
>> happening and what is a bug and what is not.
>
> Well, I'd say that should be the first step...

Exactly. That is why debug output might be helpful.

>> I just mean that the normal C code (i.e. not related to system calls)
>> seems better checked on w32.
>
> Not sure what do you mean with "better checked". Obviously it is
> easier to know what one of our own C functions is doing that what a
> Windows system call does, so it's less likely that a return code from
> a C function is ignored.

Yes, but isn't it a really good reason to always check the return code
from system calls?

> I see no practical difference between my take of the situation
> (regarding your patches) and yours.

Maybe it is just me then. But I have thrown away a good deal of them
just to get less work (even if some of them were bug fixes).

>> I have an example where I create a frame contact a web page in
>> pause.el. Is that specific enough? (You have to run my patched code to
>> see it since I can't do the frame manipulation I need without that.)
>
> Then, why are you sure the problem isn't in your code? Surely if it is
> a bug in Emacs there will be a way to show it with the trunk code?

Because they are not related to that part of the code.

>> No ;-)
>
> Hmm... allow me to disagree ;-)

What can I do? ;-)

> While debugging. Not as a general principle. I don't want to run Emacs
> under GDB for a totally unrelated reason and have a lot of noise.

Yes, of course. But keeping a commented out one line debug output call
might be quit useful in some places.

>> And the changes that allows better menu handling are also a bit
>> scaring when merging. They are still only in my code.
>
> Perhaps the latter is consequence of the former.

Yes, I know.