emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug fix needs to be put in release branch


From: Richard Stallman
Subject: Re: Bug fix needs to be put in release branch
Date: Fri, 17 Jul 2009 20:29:23 -0400

    > I installed a bug fix in the trunk that makes auto-save
    > work properly in Rmail files.  Would someone please install
    > it in the release branch?  I don't have a checkout of that,
    > and it would not be feasible to check it out here even if I had time.

    I don't think it's appropriate to make this change in the branch.

It fixes a bug.  The bug ought to be fixed before the release,
so I wrote a fix.

    Could you describe the problem you are trying to fix, and do you have a
    recipe for easily reproducing it?

If you enable auto save mode in an Rmail buffer,
auto-save mode can get turned off because the view buffer
is a lot smaller than the whole file.  The code which does this
doesn't know anything about swapping buffers, and has no hooks.

Users can enable auto save manually in an Rmail buffer.
If they do, it ought to work.

In addition, rmailout.el enables auto-save mode when it adds a message
to an Rmail file visited in a buffer.

    It should be possible to get auto-save working in Rmail without
    extending buffer-saved-size. For instance, we could change
    rmail-swap-buffers-maybe to manage the auto-save variables
    appropriately.

I wrote and tested one fix, which it works.  I don't insist on using
this fix.








reply via email to

[Prev in Thread] Current Thread [Next in Thread]