[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mouse-face highlighting broken?
From: |
YAMAMOTO Mitsuharu |
Subject: |
Re: mouse-face highlighting broken? |
Date: |
Thu, 07 May 2009 15:29:06 +0900 |
User-agent: |
Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (Shijō) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) |
>>>>> On Thu, 07 May 2009 00:46:13 -0400, Chong Yidong <address@hidden> said:
>> With that, I took a look at the relevant code in the NS port, and
>> it turns out that ns_dumpglyphs_stretch() and ns_dumpglyphs_image()
>> fail to use the mouse face instead of the first glyph face. The
>> patch below addresses that.
> This patch looks reasonable to me.
It might be OK to apply such a change for now, but I'd rather think if
the NS port had a similar code structure to the other terms, an
oversight like this case would hardly happen in the first place. The
other terms consolidate the mouse face handling into one function
x_set_mouse_face_gc rather than scattering it into 3 (the proposed
change makes it 5) places. Also, this uniformity among different
terms makes it easier for other terms to catch up with xterm.c
changes.
YAMAMOTO Mitsuharu
address@hidden
- mouse-face highlighting broken?, David Reitter, 2009/05/06
- Re: mouse-face highlighting broken?, Chong Yidong, 2009/05/06
- Re: mouse-face highlighting broken?, David Reitter, 2009/05/06
- RE: mouse-face highlighting broken?, Drew Adams, 2009/05/06
- Re: mouse-face highlighting broken?, David Reitter, 2009/05/06
- Re: mouse-face highlighting broken?, Chong Yidong, 2009/05/07
- Re: mouse-face highlighting broken?,
YAMAMOTO Mitsuharu <=
- Re: mouse-face highlighting broken?, David Reitter, 2009/05/07
- Re: mouse-face highlighting broken?, Stefan Monnier, 2009/05/07