|
From: | Jason Rumney |
Subject: | Re: [Emacs-diffs] emacs/lib-src emacsclient.c ChangeLog |
Date: | Thu, 11 Dec 2008 00:40:23 +0800 |
User-agent: | Thunderbird 2.0.0.18 (Windows/20081105) |
Juanma Barranquero wrote:
But the base discussion is whether features should be tested by feature tests, or lumped together into the WINDOWSNT, DOS_NT, NS_IMPL_* bags. We've been saying for years that Emacs lisp programs must not check the Emacs version, but features. The same reasoning applies to checking HAVE_DAEMON vs. WINDOWSNT.
When it is just not possible to support a feature because of the platform, then I have no problem using the platform constant to conditionally compile it out. But if it is just a lack of developers on a particular platform that is preventing the feature from being implemented, then it is much easier for later developers who wish to implement it if there is a feature specific constant.
NO_SOCKETS_IN_FILE_SYSTEM is sitting on a blurry line, since although Windows does not support unix domain sockets, it is conceivable that an emulation of them using named pipes could be developed in future.
[Prev in Thread] | Current Thread | [Next in Thread] |