Re: The latest lisp/faces.el changes seem to break color-themes again

[Chming]

On my side, the normal emacs startup is fine but it is broken if I am
using multi-tty with emacsclient. Yesterday, I got some errors related
to the face attribute. Today with cvs update, this is gone but still
broken for emacsclient session.

BTW, I am using color-theme.

Thanks a lot,

Max

On Thu, Oct 16, 2008 at 9:36 AM, Chong Yidong <address@hidden> wrote:
> Michael Olson <address@hidden> writes:
>
>> The problem could possibly be due to Emacs having problems with using
>> ":foreground nil" in a defface statement.  I just received a patch for
>> EMMS to that effect.
>
> I just checked in a change to make internal-set-lisp-face-attribute
> treat null foreground/background as equivalent to unspecified.  This is
> a Emacs 20'ism that ought to be phased out in your code, but AFAICT
> there's no harm handling it.
>
> Let me know if there is anything else that breaks (I don't use
> color-themes so I can't test the original report).
>
>
>