Re: tool-bar related errors when loading compile.el

[Dan Nicolaescu]

martin rudalics <address@hidden> writes:

  > >   >   (if (display-graphic-p)
  > >       ^^^^^^^^^^^^^^^^^
  > > Using this in defvars is broken.  If you start with "emacs -nw" and
  > > later create X11 frames, the defvar will not be initialized correctly
  > > for X11 frames.
  > >
  > >   > into
  > >   >
  > >   >   (if tool-bar-mode
  > >   >
  > >   > in compile.el and grep.el.
  > >
  > > Unfortunately that is not better for the same reason.
  > 
  > So even if we made `compilation-mode-tool-bar-map' a function and did
  > 
  >     (when tool-bar-mode
  >       (set (make-local-variable 'tool-bar-map)
  >            (compilation-mode-tool-bar-map)))
  > 
  > in `compilation-mode' we'd miss something?

I think so, when the buffer is initialized tool-bar-mode can be off, but
when it's displayed the user could have turned it on.