emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: inputting characters by hexadigit


From: Juri Linkov
Subject: Re: inputting characters by hexadigit
Date: Tue, 29 Jul 2008 19:07:28 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu)

>>     ;; Assume character codes 0240 - 0377 stand for characters in some
>>     ;; single-byte character set, and convert them to Emacs
>>     ;; characters.
>>     (if (and enable-multibyte-characters
>>           (>= char ?\240)
>>           (<= char ?\377))
>>      (setq char (unibyte-char-to-multibyte char)))
>
>> I don't know if this code is still valid now?
>
> Indeed, it's not valid any more.
> It should probably try something like
>
>   (aref (decode-coding-string (unibyte-string char) locale-coding-system) 0)
>
> instead, tho I'd argue that we should drop this feature and insert the
> corresponding Unicode char instead (which would give the latin-1
> equivalent as well).

So is it ok to remove this code or it's better to comment it out?

BTW, there are also warnings in the same function (and few other
places):

    In quoted-insert:
    simple.el:685:22:Warning: `translation-table-for-input' is an obsolete
        variable (as of Emacs 23.1).

Could you tell what changes this requires?

-- 
Juri Linkov
http://www.jurta.org/emacs/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]