emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v


From: Stefan Monnier
Subject: Re: [Emacs-diffs] Changes to emacs/src/emacs.c,v
Date: Mon, 28 Jul 2008 22:47:21 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

>> This hunk is wrong and breaks malloc on os x when building without
>> toolkit. The reason to have two macros, MAC_OSX and HAVE_CARBON, was to
>> distinguish bare os x support from carbon gui AFAIU.

> Unfortunately that is not what the code in configure.in said:

But that's partly what admin/CPP-DEFINES says.

> What is the right conditional there?

Of course, you can expect that some of those macros aren't always used
100% correctly either.  Which is why a good CPP-DEFINES file is
important, in order to document the intended use, so as to know which
uses are correct and which aren't.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]