Re: bug#347: C mode asks twice about local variables

[Chong Yidong]

Alan Mackenzie <address@hidden> writes:

>> 2008-06-15  Alan Mackenzie  <address@hidden>
>
>>      * progmodes/cc-mode.el (c-before-hack-hook): New function
>>      (Top Level): Install c-before-hack-hook on
>>      before-hack-local-variables-hook, rather than
>>      c-postprocess-file-styles on hack-local-variables-hook.
>
>>      * files.el (hack-local-variables-alist): New variable.
>>      (before-hack-local-variables-hook): New hook.
>>      (hack-local-variables-filter): Refactored version of
>>      Hack-local-variables-apply.
>>      (hack-local-variables): Call `before-hack-local-variables-hook'.

Looks OK to me, except for two things:

- hack-local-variables-alist, before-hack-local-variables-hook, and
  c-before-hack-hook need to be marked as risky local vars.

- how bout renaming hack-local-variables-alist to
  file-local-variables-alist (which is a better description), making it
  buffer-local, and setting its buffer value instead of let-binding it?
  Then it would provide a lasting record what vars were set in this
  buffer using the hack-local-variables mechanism, which might be a
  useful thing to have.

If no one has any other objections in a couple of days, I'd go ahead and
check it in.  Please add a note to NEWS as well.