[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Face initialization
From: |
Richard M Stallman |
Subject: |
Re: Face initialization |
Date: |
Sun, 06 Jul 2008 14:47:26 -0400 |
Also, the call to make-face-x-resource-internal seems to be
unnecessary.
SOMETHING needs to check for those X resources.
Is it done elsewhere? Is this call redundant?
I don't entirely understand what is going on in this change,
but if you think that certain steps are unnecessary,
please double check. It is easy to make mistakes in this code.
- (if (face-attribute 'default :font t)
- (set-face-attribute 'default frame :font
- (face-attribute 'default :font t))
- (set-face-attribute 'default frame :family
- (face-attribute 'default :family t))
- (set-face-attribute 'default frame :height
- (face-attribute 'default :height t))
- (set-face-attribute 'default frame :slant
- (face-attribute 'default :slant t))
- (set-face-attribute 'default frame :weight
- (face-attribute 'default :weight t))
- (set-face-attribute 'default frame :width
- (face-attribute 'default :width t)))
The purpose of that code is to initialize `default'
for this frame from the frame-independent face attributes.
If this is done elsewhere, then maybe this code is not needed,
but how about adding comments that explain all the overall logic
for giving the faces the right settings?
- Re: Face initialization, (continued)
- Re: Face initialization, Richard M Stallman, 2008/07/07
- Re: Face initialization, Chong Yidong, 2008/07/07
- Re: Face initialization, Jason Rumney, 2008/07/09
- Re: Face initialization, Chong Yidong, 2008/07/09
- Re: Face initialization, Miles Bader, 2008/07/09
- Re: Face initialization, Jason Rumney, 2008/07/10
- Re: Face initialization, Stefan Monnier, 2008/07/10
- Re: Face initialization, Jason Rumney, 2008/07/10
Re: Face initialization,
Richard M Stallman <=