[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Build failure on M$ (using MSVC): Patch enclosed
From: |
Miles Bader |
Subject: |
Re: Build failure on M$ (using MSVC): Patch enclosed |
Date: |
Thu, 22 May 2008 22:33:09 +0900 |
Jason Rumney <address@hidden> writes:
>> I think the proper fix is to consistently use either strcasecmp or
>> stricmp (or xstricmp, which we define in xfaces.c, though the other
>> two are widely enough used that it seems unnecessary to define yet
>> another function). Historically we seem to have settled on stricmp
>> except in dosfns.c and unexcw.c, which are only compiled on DOS and
>> Cygwin respectively. Even those should be changed for consistency.
>
> Actually, only Windows code seems to use stricmp in Emacs 22.2, so we
> should probably replace uses of both strcasecmp and stricmp with
> xstricmp for consistency.
But let's change the name to xstrcasecmp, as strcasecmp is the posix/gnu
name.
-miles
--
Kilt, n. A costume sometimes worn by Scotchmen [sic] in America and Americans
in Scotland.
- Re: Build failure on M$ (using MSVC): Patch enclosed, (continued)
- Re: Build failure on M$ (using MSVC): Patch enclosed, Stefan Monnier, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, Stefan Monnier, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, dhruva, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, Eli Zaretskii, 2008/05/23
- Re: Build failure on M$ (using MSVC): Patch enclosed, Jason Rumney, 2008/05/23
- Re: Build failure on M$ (using MSVC): Patch enclosed, Jason Rumney, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, dhruva, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, dhruva, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, Jason Rumney, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed, Jason Rumney, 2008/05/22
- Re: Build failure on M$ (using MSVC): Patch enclosed,
Miles Bader <=