Re: Build failure on M$ (using MSVC): Patch enclosed

[David Kastrup]

dhruva <address@hidden> writes:

> On 5/22/08, Stefan Monnier <address@hidden> wrote:
>> > Well, I was not aware of that function. Looking a little deeper into
>>  > it, it does not traverse above the current user $HOME (~/ or %HOME%).
>>  > This code needs to go all the way till the top. Since it does a
>>  > username comparison, it apprears a bit more expensive (based on gut
>>  > feel though).
>>
>>
>> Indeed, it doesn't go up past the home directory and it doesn't lookup
>>  past a directory with a different owner.  It's all done on purpose to
>>  try and avoid pathological cases.
>>  I don't see that as a problem at all.
>
> Though I do not see a practical use case, here is a case where it can fail:
>
> 1. As a system wide policy, I put some settings file in the root
> folder or the parent folder of every user folder which has a bunch of
> defaults

There is no necessity whatsoever to use the settings file mechanism for
global defaults.  Just set the appropriate variables in site-start.el.

On a different tack: why can't vc-find-root be made to use
locate-dominating-file?  One less bunch of heuristics to maintain.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum