emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] Changes to emacs/lisp/info.el,v


From: Karl Fogel
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/info.el,v
Date: Fri, 07 Mar 2008 00:49:46 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Stefan Monnier <address@hidden> writes:
> --- info.el   6 Mar 2008 21:43:06 -0000       1.515
> +++ info.el   7 Mar 2008 05:00:17 -0000       1.516
> @@ -4373,8 +4373,7 @@
>           (forward-str            (bookmark-get-front-context-string bmk))
>           (behind-str             (bookmark-get-rear-context-string bmk))
>           (place                  (bookmark-get-position bmk))
> -      (info-node              (bookmark-get-info-node bmk))
> -      (orig-file              file))
> +      (info-node              (bookmark-get-info-node bmk)))
>      (if (setq file (bookmark-file-or-variation-thereof file))
>          (save-excursion
>            (save-window-excursion

`bookmark-get-info-node' is still being used here, but `bookmark.el' no
longer defines it as of revision 1.102.  Did you test? :-)

I was on the way to making what probably would have been the same
changes, when I updated and got your changes, so we're clearly on the
same page here!  See my commits immediately after yours.  I don't mean
to imply that I would not have written a bug, by the way -- it might not
have been this *particular* bug, but it would have been *some* bug.

-Karl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]