Re: vc-set-mode-line-busy-indicator

[Glenn Morris]

Richard Stallman wrote:

>     Yes. mode-line-highlight (as now) for things you might click, which are
>     highlighted as buttons on mouse-over. mode-line-emphasis for
>     "non-interactive" things you don't click, which are always highlighted.
>
> 1. Do we really need both?  (I am worried about face bloat.)

No. vc-set-mode-line-busy-indicator can not apply a 'face property for
all I care. (I knew this worry about "face bloat" would come up. I
don't understand it.)

> 2. If we need both, the name of the one for buttons should be
> `mode-line-button' and the one for emphasis should be
> `mode-line-highlight'.

This would be an incompatible change to the use of the existing
mode-line-highlight face.

> 3. Can we make the one for buttons by means of `button'
> instead of having a separate face only for mode line buttons?

I'll say, once again, that the mode-line has a different colour scheme
to the buffer. Trying to re-use buffer faces in the mode-line can look
very poor, as at present with vc-set-mode-line-busy-indicator.


I've said all I have to say on this. I've said why the current choice
is bad, and I've offered two alternatives (using no 'face at all, or a
new one). I'll implement either. But please let's do something,
because the current behaviour is broken.