Re: New Emacs facilities from Gnus

[Reiner Steib]

On Fri, Nov 09 2007, Sascha Wilde wrote:

> Stefan Monnier <address@hidden> wrote:
>>> +     (if (or (featurep 'xemacs)
>>> +             ;; For Emacs >= 22 we don't need smime-ldap.el
>>> +             (>= emacs-major-version 22))

Correction:
                  (< emacs-major-version 22)

>>> +         (progn
>>> +           (require 'smime-ldap)
> [...]
>> Those kinds of test qualify as "yucky" in my book.

I guess you mean the version check?  Yes, I don't like it, but I can't
think of a better test in this case.

>> I'd rather do
>>
>> (ignore-errors (require 'smime-ldap)) 

This would unnecessarily load and use smime-ldap in Emacs 22+
e.g. when using the standalone Gnus distribution (or if smime-ldap.el
is present in load-path).

>> and then (fboundp 'smime-ldap-search).

> Emacs 22 require has an optional argument NOERROR, so 
> (require 'smime-ldap nil t) 
> would be safe (and one can use the return value).  But I don't know if
> it is portable...

XEmacs 21.4 doesn't have it, IIRC.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/