[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] lisp/net/browse-url.el: Bugfixes regarding Elinks support (i
From: |
Michaël Cadilhac |
Subject: |
Re: [PATCH] lisp/net/browse-url.el: Bugfixes regarding Elinks support (improved resend) |
Date: |
Wed, 19 Sep 2007 13:32:43 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) |
Johannes Weiner <address@hidden> writes:
> On Wed, Sep 19, 2007 at 11:58:09AM +0200, Michaël Cadilhac wrote:
>> Johannes Weiner <address@hidden> writes:
>> > The current browse-url-elinks function is broken!
>> >
>> > Patch including ChangeLog entry attached.
>>
>> Can you please send me this patch updated against the current CVS
>> repository?
>
> Yes. Patch attached.
Thank you, perfect, installed! (Except that a period should be followed
by two spaces when it ends a sentence, and that one entry of the
ChangeLog didn't use the imperative.)
> PS: You renamed the first argument in browse-url-url-encode-chars to
> `text' but the function body still refers to `url'. It works thanks
> to dynamic scoping, but I think this is not what you intended (since
> `text' is never used at all in the body).
Yek, dash it! You're utterly right, thanks for the report.
--
| Michaël `Micha' Cadilhac | Libertude, |
| http://michael.cadilhac.name | Égalitude, |
| JID/MSN: | Fraternitude. |
`---- address@hidden | -- À peu près S.R. - --'
pgpFTpMSIa_oM.pgp
Description: PGP signature