[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Long standing warnings in C files.
From: |
Michaël Cadilhac |
Subject: |
Long standing warnings in C files. |
Date: |
Sun, 16 Sep 2007 16:49:00 +0200 |
User-agent: |
Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) |
There's some long-standing warnings in xterm.c and coding.c that we
probably should get rid of.
I don't think the following patch could break anything, but I prefer
to ask.
Warnings :
coding.c:4468: warning: passing argument 1 of 'detect_eol_type_in_2_octet_form'
discards qualifiers from pointer target type
coding.c:4471: warning: passing argument 1 of 'detect_eol_type_in_2_octet_form'
discards qualifiers from pointer target type
coding.c:4474: warning: passing argument 1 of 'detect_eol_type' discards
qualifiers from pointer target type
coding.c: In function 'detect_coding_system':
coding.c:6603: warning: passing argument 1 of 'detect_eol_type' discards
qualifiers from pointer target type
xterm.c: In function 'handle_one_xevent':
xterm.c:6644: warning: passing argument 2 of 'note_mouse_movement' from
incompatible pointer type
xterm.c:6677: warning: passing argument 2 of 'note_mouse_movement' from
incompatible pointer type
Patch :
Index: xterm.c
===================================================================
RCS file: /sources/emacs/emacs/src/xterm.c,v
retrieving revision 1.957
diff -B -w -c -r1.957 xterm.c
*** xterm.c 14 Sep 2007 04:11:26 -0000 1.957
--- xterm.c 16 Sep 2007 14:48:44 -0000
***************
*** 6641,6647 ****
/* We may get an EnterNotify on the buttons in the toolbar. In that
case we moved out of any highlighted area and need to note this. */
if (!f && last_mouse_glyph_frame)
! note_mouse_movement (last_mouse_glyph_frame, &event);
#endif
goto OTHER;
--- 6641,6647 ----
/* We may get an EnterNotify on the buttons in the toolbar. In that
case we moved out of any highlighted area and need to note this. */
if (!f && last_mouse_glyph_frame)
! note_mouse_movement (last_mouse_glyph_frame, &event.xmotion);
#endif
goto OTHER;
***************
*** 6674,6680 ****
#ifdef USE_GTK
/* See comment in EnterNotify above */
else if (last_mouse_glyph_frame)
! note_mouse_movement (last_mouse_glyph_frame, &event);
#endif
goto OTHER;
--- 6674,6680 ----
#ifdef USE_GTK
/* See comment in EnterNotify above */
else if (last_mouse_glyph_frame)
! note_mouse_movement (last_mouse_glyph_frame, &event.xmotion);
#endif
goto OTHER;
Index: coding.c
===================================================================
RCS file: /sources/emacs/emacs/src/coding.c,v
retrieving revision 1.355
diff -B -w -c -r1.355 coding.c
*** coding.c 29 Aug 2007 05:27:58 -0000 1.355
--- coding.c 16 Sep 2007 14:48:47 -0000
***************
*** 4335,4344 ****
static int
detect_eol_type (source, src_bytes, skip)
! unsigned char *source;
int src_bytes, *skip;
{
! unsigned char *src = source, *src_end = src + src_bytes;
unsigned char c;
int total = 0; /* How many end-of-lines are found so far. */
int eol_type = CODING_EOL_UNDECIDED;
--- 4335,4344 ----
static int
detect_eol_type (source, src_bytes, skip)
! const unsigned char *source;
int src_bytes, *skip;
{
! const unsigned char *src = source, *src_end = src + src_bytes;
unsigned char c;
int total = 0; /* How many end-of-lines are found so far. */
int eol_type = CODING_EOL_UNDECIDED;
***************
*** 4384,4393 ****
static int
detect_eol_type_in_2_octet_form (source, src_bytes, skip, big_endian_p)
! unsigned char *source;
int src_bytes, *skip, big_endian_p;
{
! unsigned char *src = source, *src_end = src + src_bytes;
unsigned int c1, c2;
int total = 0; /* How many end-of-lines are found so far. */
int eol_type = CODING_EOL_UNDECIDED;
--- 4384,4393 ----
static int
detect_eol_type_in_2_octet_form (source, src_bytes, skip, big_endian_p)
! const unsigned char *source;
int src_bytes, *skip, big_endian_p;
{
! const unsigned char *src = source, *src_end = src + src_bytes;
unsigned int c1, c2;
int total = 0; /* How many end-of-lines are found so far. */
int eol_type = CODING_EOL_UNDECIDED;
If no one complains, I'll install that in a few days.
--
| Michaël `Micha' Cadilhac | I am very sad for you |
| http://michael.cadilhac.name | that you are running |
| JID/MSN: | Windows Vista. |
`---- address@hidden | -- RMS - --'
pgpecBmswoQC6.pgp
Description: PGP signature
- Long standing warnings in C files.,
Michaël Cadilhac <=