Re: font-backend mechanism on Windows and Mac?

[Jason Rumney]

Kenichi Handa wrote:
> In article <address@hidden>, Jason Rumney <address@hidden> writes:
>
> Which part of comment do you mean?
>   

  /* Perform the size computation of glyphs of FONT and fillin members
     of METRICS.  The glyphs are specified by their glyph codes in
     CODE (length NGLYPHS).  */

It is clear from that comment that multiple glyphs can be passed to that
function, but it is not clear that metrics is a single struct. I
originally implemented it as if metrics was an array of length nglyphs,
but the implementation in xftfont.c seems to suggest a single struct.

>> In the case
>> where metrics is NULL, the Windows version does do a full string
>> determination, but it has to convert the unsigned array of characters to
>> a short array for the Windows API functions.
>>     
>
> ??? text_extents should always be called with non-NULL
> metrics arg.
>   

font.c:1948 nglyphs=1, metrics=NULL
font.c:3726 nglyphs=i, metrics=NULL

font.c:2012 nglyphs=1, metrics=&metrics
font.c:3642 nglyphs=1, metrics=&metrics