[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Your last change to browse-url is bogus.
From: |
Davis Herring |
Subject: |
Re: Your last change to browse-url is bogus. |
Date: |
Wed, 12 Sep 2007 19:39:53 -0700 (PDT) |
User-agent: |
SquirrelMail/1.4.8-6.el3.2lanl |
> That depends on how you look at it. If you think of them as
> operations on characters, they're the same. If you think of them as
> operations on strings, they're different (ie, it's possible to find
> strings which are not transformed tthe same way by both operations).
> [...]
> In that case it would make sense to give the escaping function that
> takes the set of characters an "-internal" or "-helper" name (excuse
> me, I don't know the GNU conventions for this), and use nice efficient
> defsubsts for the semantically mnemonic public entry points.
I think I agree, and that the first paragraph above (perhaps
unintentionally) supports the second. It is an implementation detail that
the filename->URL and other->URL (I don't remember the other item)
operations, which are semantically different, can use the same
string-substitution subroutine. So I'd rename the function in question to
"browse-url-escape-chars" and then have "browse-url-escape-filename" and
"browse-url-escape-<other>" that called it.
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.
- Re: Your last change to browse-url is bogus., (continued)
- Re: Your last change to browse-url is bogus., YAMAMOTO Mitsuharu, 2007/09/12
- Re: Your last change to browse-url is bogus., Michaël Cadilhac, 2007/09/12
- Re: Your last change to browse-url is bogus., YAMAMOTO Mitsuharu, 2007/09/12
- Re: Your last change to browse-url is bogus., Michaël Cadilhac, 2007/09/12
- Re: Your last change to browse-url is bogus., YAMAMOTO Mitsuharu, 2007/09/17
- Re: Your last change to browse-url is bogus., Michaël Cadilhac, 2007/09/17
- Re: Your last change to browse-url is bogus., Stephen J. Turnbull, 2007/09/12
- Re: Your last change to browse-url is bogus., Stefan Monnier, 2007/09/12
- Re: Your last change to browse-url is bogus., Stephen J. Turnbull, 2007/09/13
- Re: Your last change to browse-url is bogus., Stefan Monnier, 2007/09/13
- Re: Your last change to browse-url is bogus.,
Davis Herring <=