[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 22.1.1; Frame title no more updated after calling `set-frame-configu
From: |
martin rudalics |
Subject: |
Re: 22.1.1; Frame title no more updated after calling `set-frame-configuration' |
Date: |
Sat, 08 Sep 2007 10:45:02 +0200 |
User-agent: |
Mozilla Thunderbird 1.0 (Windows/20041206) |
>>emacs -Q --eval '(set-frame-configuration (current-frame-configuration))'
>>
>>segfaults in x_set_frame_parameters.
>
>
>
> Seems (?) to work ok with the following extra change:
>
>
> *** frame.c 25 Jul 2007 05:15:52 -0000 1.340.2.1
> --- frame.c 7 Sep 2007 22:51:56 -0000
> *** 2768,2773 ****
> --- 2770,2778 ----
> icon_top = val;
> else if (EQ (prop, Qicon_left))
> icon_left = val;
> + else if (EQ (prop, Qexplicit_name))
> + /* Handled elsewhere. */
> + continue;
> else if (EQ (prop, Qforeground_color)
> || EQ (prop, Qbackground_color)
> || EQ (prop, Qfont)
>
This would be needed in any case because "explicit-name" should never
get assigned to by `modify-frame-parameters'. I'm not entirely sure
though whether every possible setting of "name" gets correctly reflected
in "explicit-name", but such a bug would have existed before. At least
I'm tempted to move the
f->explicit_name = ! NILP (name);
in set_term_frame_name as
f->explicit_name = Qt;
to the end of the else branch below to catch the cases where there's no
change either because the strings are equal or there's a name clash, but
that's probably only a minor issue.
I wouldn't care if anyone came up with a completely different solution ;-)