[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
address@hidden: Highlight advice (was: Multiple major modes)]
From: |
Richard Stallman |
Subject: |
address@hidden: Highlight advice (was: Multiple major modes)] |
Date: |
Tue, 04 Sep 2007 18:58:12 -0400 |
Please install this and ack.
------- Start of forwarded message -------
X-Spam-Status: No, score=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS,
UNPARSEABLE_RELAY autolearn=failed version=3.1.0
Mail-Followup-To: address@hidden
To: address@hidden
From: address@hidden (Johan =?utf-8?Q?Bockg=C3=A5rd?=)
Date: Tue, 04 Sep 2007 11:03:30 +0200
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Mail-Copies-To: never
Subject: Highlight advice (was: Multiple major modes)
Richard Stallman <address@hidden> writes:
> > I often do that, but I don't read carefully thru the buffer thaht
> > `describe-function' displays. If it said something about advice, I
> > wouldn't even notice, unless I read carefully thru the buffer to look
> > for such. And I am in too much of a hurry to make a practice
> > of always reading that text carefully.
>
> Did someone already say "highlight the advice info" in the help buffer?
>
> I have doubts that it will help that much, but it can't hurt. Would
> someone please implement it?
2007-09-04 Johan Bockgård <address@hidden>
* emacs-lisp/advice.el (ad-make-advised-docstring): Highlight note
in doc string.
Index: lisp/emacs-lisp/advice.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/advice.el,v
retrieving revision 1.54
diff -u -r1.54 advice.el
- --- lisp/emacs-lisp/advice.el 28 Jul 2007 19:57:22 -0000 1.54
+++ lisp/emacs-lisp/advice.el 4 Sep 2007 08:44:59 -0000
@@ -2996,7 +2996,9 @@
(setq usage (if (null usage) t (setq origdoc (cdr usage)) (car usage)))
(if origdoc (setq paragraphs (list origdoc)))
(unless (eq style 'plain)
- - (push (concat "This " origtype " is advised.") paragraphs))
+ (push (propertize (concat "This " origtype " is advised.")
+ 'face 'font-lock-warning-face)
+ paragraphs))
(ad-dolist (class ad-advice-classes)
(ad-dolist (advice (ad-get-enabled-advices function class))
(setq advice-docstring
- --
Johan Bockgård
_______________________________________________
Emacs-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------
- address@hidden: Highlight advice (was: Multiple major modes)],
Richard Stallman <=