[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Failure in building Emacs 23.0.50 on Cygwin
From: |
d.henman |
Subject: |
Re: Failure in building Emacs 23.0.50 on Cygwin |
Date: |
Sat, 01 Sep 2007 19:14:15 +0900 |
I also feel that defining a "croak" for cygwin and all other platforms in
sysdep.c is
a better one.
After all that is what sysdep.c is for, I should think...
But, I don't have sufficient knowledge at this point, other thatn to make it
functionwith no processing thet simply returns a zero, for o.k.
Regards,
Darel Henman
Eli Zaretskii <address@hidden> wrote:
> > From: "d.henman" <address@hidden>
> > Date: Sat, 01 Sep 2007 12:53:13 +0900
> > Cc: address@hidden
> >
> > --- term.c 2007-08-30 06:46:50.000000000 +0900
> > +++ term.c.fixed 2007-09-01 10:39:51.906250000 +0900
> > @@ -3142,8 +3142,10 @@
> > emacs_close (fd);
> > sigunblock (sigmask (SIGTTOU));
> > #else
> > +#ifndef CYGWIN
> > /* Unknown system. */
> > croak ();
> > +#endif /* ! CYGWIN */
> > #endif /* ! TIOCNOTTY */
> > #endif /* ! USG */
> > }
> >
> > --=-=-=
> >
> >
> > Please review this and let me know if I can check it into cvs.
>
> Please don't, as I think it;s the wrong way of fixing the problem.
>
> I think the idea of defining `croak' for all platforms in sysdep.c is
> a better one.