Re: address@hidden: Locale Dependent Downcasing in smtpmail]

[Eli Zaretskii]

> From: Kenichi Handa <address@hidden>
> Date: Tue, 03 Apr 2007 17:06:07 +0900
> Cc: address@hidden, address@hidden
> 
> To avoid such an ad-hoc fix, I must know the purpose of
> downcasing here.  Do we need just "tr A-Z a-z"?  Or, do we
> have to downcase also non-ASCII chars?

I think the purpose is quite obvious from this fragment:

            (smtpmail-send-command process (format "EHLO %s" (smtpmail-fqdn)))

            (if (or (null (car (setq response-code
                                     (smtpmail-read-response process))))
                    (not (integerp (car response-code)))
                    (>= (car response-code) 400))
                (progn
                  ;; HELO
                  (smtpmail-send-command
                   process (format "HELO %s" (smtpmail-fqdn)))

                  (if (or (null (car (setq response-code
                                           (smtpmail-read-response process))))
                          (not (integerp (car response-code)))
                          (>= (car response-code) 400))
                      (throw 'done nil)))
              (dolist (line (cdr (cdr response-code)))
                (let ((name (mapcar (lambda (s) (intern (downcase s)))
                                    (split-string (substring line 4) "[ ]"))))
                  (and (eq (length name) 1)
                       (setq name (car name)))
                  (and name
                       (cond ((memq (if (consp name) (car name) name)
                                    '(verb xvrb 8bitmime onex xone
                                           expn size dsn etrn
                                           enhancedstatuscodes
                                           help xusr
                                           auth=login auth starttls))
                              (setq supported-extensions
                                    (cons name supported-extensions)))
                             (smtpmail-warn-about-unknown-extensions
                              (message "Unknown extension %s" name)))))))

My interpretation of this is that smtpmail sends EHLO/HELO command to
the SMTP server, and then examines the response, which specifies the
features supported by the server as a list of strings separated by
whitespace.  For each such feature, we downcase and intern it, and
then check whether the resulting symbol is a member of the list of
features known to smtpmail, it adds the feature to the
supported-extensions list.  Thus, downcasing needs to support only the
words in the above list of known extensions (verb, xvrb, 8bitmime,
etc.), which are pure-ASCII words.

IOW, "tr A-Z a-z" should be enough.

Simon, am I right?