[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] autorevert.el -- revert fix for Windows platform
From: |
Kim F. Storm |
Subject: |
Re: [PATCH] autorevert.el -- revert fix for Windows platform |
Date: |
Sun, 25 Mar 2007 00:50:11 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>>> For the release, I'd say Jari's patch is good enough!
>
>> I'm not sure, do we really expect buffer-size to be the same as the number
>> of bytes in the file, potentially in the presence of multibyte characters?
>> This change is quite likely to break things if that assumption is
>> not correct.
>
> Duh, I didn't even look at the patch. So no clearly the patch is
> unacceptable as is. But the principle of checking whether the file changes
> size is the thing I agreed to.
Me too.
I didn't think deeply about the implications of using (buffer-size)
directly, but what about using (position-bytes (buffer-size)) instead?
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, (continued)
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Jari Aalto, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Eli Zaretskii, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Kim F. Storm, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Jason Rumney, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Luc Teirlinck, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Eli Zaretskii, 2007/03/24
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Stefan Monnier, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform,
Kim F. Storm <=
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Luc Teirlinck, 2007/03/24
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Kim F. Storm, 2007/03/24
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Stefan Monnier, 2007/03/25
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Stefan Monnier, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Eli Zaretskii, 2007/03/24
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Eli Zaretskii, 2007/03/23
- Re: [PATCH] autorevert.el -- revert fix for Windows platform, Richard Stallman, 2007/03/22