Re: momentary-string-display

[Tak Ota]

Wed, 03 Jan 2007 16:11:01 -0500: Richard Stallman <address@hidden> wrote:

>     > I see two uses of momentary-string-display in table.el which perhaps
>     > should be replaced by calls to display-warning.
>     > Takaaki-san, do you think that is a good idea?
> 
>     I compared the behavior of the two functions and I prefer
>     momentary-string-display.  However, I don't object replacing it with
>     display-warning.
> 
> Would you please do that, for the two uses in table.el?
> 

Sure.  Could you have someone check in the attached patch?

-Tak


2007-01-03  Takaaki Ota  <address@hidden>

        * textmodes/table.el (table--warn-incompatibility): replace all
        momentary-string-display with display-warning.

*** emacs-22.0.91/lisp/textmodes/table.el       Wed Jan  3 13:29:35 2007
--- ../../../emacs/emacs-22.0.91/lisp/textmodes/table.el        Wed Jan  3 
13:23:46 2007
***************
*** 6,12 ****
  ;; Keywords: wp, convenience
  ;; Author: Takaaki Ota <address@hidden>
  ;; Created: Sat Jul 08 2000 13:28:45 (PST)
! ;; Revised: Thu Jul 20 2006 17:30:09 (PDT)
  
  ;; This file is part of GNU Emacs.
  
--- 6,12 ----
  ;; Keywords: wp, convenience
  ;; Author: Takaaki Ota <address@hidden>
  ;; Created: Sat Jul 08 2000 13:28:45 (PST)
! ;; Revised: Wed Jan 03 2007 13:23:46 (PST)
  
  ;; This file is part of GNU Emacs.
  
***************
*** 5358,5364 ****
      (cond ((and (featurep 'xemacs)
                (not (get 'table-disable-incompatibility-warning 'xemacs)))
           (put 'table-disable-incompatibility-warning 'xemacs t)
!          (momentary-string-display
            "
  *** Warning ***
  
--- 5358,5364 ----
      (cond ((and (featurep 'xemacs)
                (not (get 'table-disable-incompatibility-warning 'xemacs)))
           (put 'table-disable-incompatibility-warning 'xemacs t)
!          (display-warning 'table
            "
  *** Warning ***
  
***************
*** 5369,5380 ****
  aware of this.
  
  "
!           (save-excursion (forward-line 1) (point))))
          ((and (boundp 'flyspell-mode)
                flyspell-mode
                (not (get 'table-disable-incompatibility-warning 'flyspell)))
           (put 'table-disable-incompatibility-warning 'flyspell t)
!          (momentary-string-display
            "
  *** Warning ***
  
--- 5369,5380 ----
  aware of this.
  
  "
!           :warning))
          ((and (boundp 'flyspell-mode)
                flyspell-mode
                (not (get 'table-disable-incompatibility-warning 'flyspell)))
           (put 'table-disable-incompatibility-warning 'flyspell t)
!          (display-warning 'table
            "
  *** Warning ***
  
***************
*** 5383,5389 ****
  works better than the previous versions however not fully compatible.
  
  "
!           (save-excursion (forward-line 1) (point))))
          )))
  
  (defun table--cell-blank-str (&optional n)
--- 5383,5389 ----
  works better than the previous versions however not fully compatible.
  
  "
!           :warning))
          )))
  
  (defun table--cell-blank-str (&optional n)