[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug in incremental undrawing of mouseover highlighting
From: |
Kim F. Storm |
Subject: |
Re: Bug in incremental undrawing of mouseover highlighting |
Date: |
Sun, 26 Nov 2006 20:05:03 +0100 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
> As to the concerns expressed by Yamamoto Mitsuharu, I would also
> suggest that a redisplay expert looks into them.
Chong's patch may not be the cleanest approach, but I think it is ok.
However, it may be better to move the setup of dpyinfo into the
BLOCK_INPUT region, like this:
*** window.c 26 Nov 2006 12:21:36 +0100 1.566
--- window.c 26 Nov 2006 20:02:48 +0100
***************
*** 3267,3274 ****
int count = SPECPDL_INDEX ();
#ifdef HAVE_WINDOW_SYSTEM
struct frame *f = XFRAME (w->frame);
! Display_Info *dpyinfo = (f && FRAME_X_OUTPUT (f)) ?
! FRAME_X_DISPLAY_INFO (f) : NULL;
#endif
w->buffer = buffer;
--- 3267,3273 ----
int count = SPECPDL_INDEX ();
#ifdef HAVE_WINDOW_SYSTEM
struct frame *f = XFRAME (w->frame);
! Display_Info *dpyinfo;
#endif
w->buffer = buffer;
***************
*** 3352,3358 ****
#ifdef HAVE_WINDOW_SYSTEM
BLOCK_INPUT;
! if (dpyinfo && EQ (window, dpyinfo->mouse_face_window))
clear_mouse_face (dpyinfo);
UNBLOCK_INPUT;
#endif
--- 3351,3359 ----
#ifdef HAVE_WINDOW_SYSTEM
BLOCK_INPUT;
! if (f && FRAME_X_OUTPUT (f)
! && (dpyinfo = FRAME_X_DISPLAY_INFO (f))
! && EQ (window, dpyinfo->mouse_face_window))
clear_mouse_face (dpyinfo);
UNBLOCK_INPUT;
#endif
--
Kim F. Storm <address@hidden> http://www.cua.dk
- Re: Bug in incremental undrawing of mouseover highlighting, (continued)
Re: Bug in incremental undrawing of mouseover highlighting, YAMAMOTO Mitsuharu, 2006/11/24
- Re: Bug in incremental undrawing of mouseover highlighting, Chong Yidong, 2006/11/24
- Re: Bug in incremental undrawing of mouseover highlighting, YAMAMOTO Mitsuharu, 2006/11/25
- Re: Bug in incremental undrawing of mouseover highlighting, Eli Zaretskii, 2006/11/25
- Re: Bug in incremental undrawing of mouseover highlighting, Chong Yidong, 2006/11/25
- Re: Bug in incremental undrawing of mouseover highlighting, Eli Zaretskii, 2006/11/25
- Re: Bug in incremental undrawing of mouseover highlighting,
Kim F. Storm <=