emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} do


From: Giorgos Keramidas
Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist
Date: Thu, 12 Oct 2006 16:12:32 +0300

On 2006-10-12 14:47, Andreas Schwab <address@hidden> wrote:
>Giorgos Keramidas <address@hidden> writes:
>> It seems to include this part:
>>
>> +       if [ ! -d ${INSTALLDIR} ] ; then \
>> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> +       else true; fi
>>
>> We don't really *need* to have an else branch in all statements.  We can
>> write this as:
>>
>> +       if [ ! -d ${INSTALLDIR} ] ; then \
>> +          ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \
>> +       fi
> 
> Except that some old shells will cause the whole command to fail if the
> condition fails.

I see.  I didn't know about this.  Thanks for the clarification :)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]