Re: shell-command - missing shell-quote-argument for program?

[Lennart Borgman]

Lennart Borgman wrote:
> Lennart Borgman wrote:
> > In some places the program to run from `shell-command' is not quoted 
> > by `shell-quote-argument'. Examples are the calls in emerge.el.
> >
> > Should not the program name be quoted by `shell-quote-argment' when 
> > it is possible?
>
> And I should have mentioned `shell-command-to-string' to of course. 
> More examples of probably missing shell quotings are in
>
> - filesets.el

The author of filesets Thomas Link has replied to me that he currently 
does not use Emacs and cannot maintain filesets.el until that situation 
changes.

I myself therefore suggest the following patch to filesets.el:

Index: filesets.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/filesets.el,v
retrieving revision 1.29
diff -c -r1.29 filesets.el
*** filesets.el    13 Aug 2006 17:05:12 -0000    1.29
--- filesets.el    6 Oct 2006 13:15:12 -0000
***************
*** 1701,1707 ****
           ok)
           t)))
     (when ok
!       (let ((cmd (format txt (buffer-file-name))))
     (message "Filesets: %s" cmd)
     (filesets-cmd-show-result cmd
                   (shell-command-to-string cmd))))))
--- 1701,1707 ----
           ok)
           t)))
     (when ok
!       (let ((cmd (format txt (shell-quote-argument (buffer-file-name)))))
     (message "Filesets: %s" cmd)
     (filesets-cmd-show-result cmd
                   (shell-command-to-string cmd))))))