Re: [bug] read-passwd of CVS Emacs

[Johan Bockgård]

Kevin Rodgers <address@hidden> writes:

> David Kastrup wrote:
>> Kevin Rodgers <address@hidden> writes:
>> 
>>> Kazu Yamamoto (山本和彦) wrote:
>>>> If the CONFIRM argument is specified to read-passwd of CVS Emacs, it
>>>> causes an error after a user type a first password.
>>>>
>>>>    (read-passwd "password: " t)
>>> The error is "Attempt to modify read-only object" and is somehow caused
>>> by a string indexing bug.  Here's a patch:
> ...
>> Looks like causing trouble when the prompt is an empty string. And
>> it looks like it would leave the properties off the last character
>> of the prompt. Correct?
>
> You're right on both counts -- thanks for catching that! I should
> have investigated further before posting a patch that has nothing to
> do with the underlying error.

Your latest patch also has nothing to do with it AFAICT. The string is
in pure storage--you need to make a copy.

-- 
Johan Bockgård