[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Cursor in non-selected windows is 1 pixel too small
From: |
Eli Zaretskii |
Subject: |
Re: Cursor in non-selected windows is 1 pixel too small |
Date: |
Sat, 04 Mar 2006 16:16:03 +0200 |
> Date: Sat, 04 Mar 2006 11:33:11 +0100
> From: Markus Gritsch <address@hidden>
> CC: address@hidden
>
> I am also using WinXP. The attached screenshot shows an Emacs started
> with -q. The cursor seen there in the lower window is clearly one pixel
> smaller in vertical direction.
Well, I wouldn't say it's ``clearly one pixel smaller''. Perhaps I'm
too blind.
Anyway, I eventually convinced myself you were right. Does the
following patch give good results?
> You are of course running a recent CVS Emacs, arn't you?
Yes.
Btw, I'm not sure I understand why xdisp.c:get_phys_cursor_geometry
decrements by one the value of height it computes:
*heightp = h - 1;
Kim, can you comment on that? Is it possible that this problem is not
specific to MS-Windows?
Index: src/w32term.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
retrieving revision 1.238
diff -u -p -r1.238 w32term.c
--- src/w32term.c 6 Feb 2006 15:23:22 -0000 1.238
+++ src/w32term.c 4 Mar 2006 14:11:40 -0000
@@ -4946,7 +4946,7 @@ x_draw_hollow_cursor (w, row)
/* Compute frame-relative coordinates for phys cursor. */
rect.left = WINDOW_TEXT_TO_FRAME_PIXEL_X (w, w->phys_cursor.x);
rect.top = get_phys_cursor_geometry (w, row, cursor_glyph, &h);
- rect.bottom = rect.top + h;
+ rect.bottom = rect.top + h + 1;
rect.right = rect.left + w->phys_cursor_width;
hdc = get_frame_dc (f);
- Cursor in non-selected windows is 1 pixel too small, Markus Gritsch, 2006/03/03
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Markus Gritsch, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Markus Gritsch, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Markus Gritsch, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small,
Eli Zaretskii <=
- Re: Cursor in non-selected windows is 1 pixel too small, Markus Gritsch, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, Kim F. Storm, 2006/03/04
- Re: Cursor in non-selected windows is 1 pixel too small, YAMAMOTO Mitsuharu, 2006/03/05
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/05
- Re: Cursor in non-selected windows is 1 pixel too small, YAMAMOTO Mitsuharu, 2006/03/05
- Re: Cursor in non-selected windows is 1 pixel too small, Kim F. Storm, 2006/03/06
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/11
- Re: Cursor in non-selected windows is 1 pixel too small, YAMAMOTO Mitsuharu, 2006/03/11
- Re: Cursor in non-selected windows is 1 pixel too small, Eli Zaretskii, 2006/03/11