emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: add-log.el


From: Richard M. Stallman
Subject: Re: add-log.el
Date: Sat, 29 Oct 2005 01:13:33 -0400

    > +(defcustom add-log-indent-text 0
    > +  "*How many spaces to indent subsequent lines in a change entry."

    It doesn't seem correct to set this sort of parameter using defcustom
    -- the proper value depends on the _file_ not the user.

I tend to agree that this should be an ordinary defvar, not a
defcustom.

But there are other variables for which arguably the same thing is the
case: add-log-time-format, and add-log-keep-changes-together.  Should
they be changed to defvars?

The first, perhaps nobody ever thinks of changing.  The second,
perhaps is a matter of personal preference as well as a matter of each
file's convention.

If we leave them as defcustoms, maybe this one should be a defcustom
too, just for regularity.

    What about making a derived-mode that derives from change-log-mode and
    overrides only that one parameter?

That would be much more cumbersome than setting the variable
in an ordinary local variables list.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]