Re: __GNUC__ == "mingw" in w32.c

[Eli Zaretskii]

> Date: Wed, 8 Jun 2005 18:05:19 +0200
> From: Juanma Barranquero <address@hidden>
> 
> >From w32.c:
> 
>   #ifdef _MSC_VER
>   #define COMPILER_NAME   "msvc"
>   #else
>   #ifdef __GNUC__
>   #define COMPILER_NAME   "mingw"
>   #else
>   #define COMPILER_NAME   "unknown"
>   #endif
>   #endif
> 
> Is there any reason to consider any _GNUC_ compiler as "mingw"?

As Jason points out, this is the only GCC port supported by the w32
build.

> Wouldn't be more sensible to use
> 
>   #ifdef _MSC_VER
>   #define COMPILER_NAME "msvc"
>   #else
>   #ifdef __MINGW32__
>   #define COMPILER_NAME "mingw"
>   #else
>   #ifdef __GNUC__
>   #define COMPILER_NAME "gcc"
>   #else
>   #define COMPILER_NAME "unknown"
>   #endif
>   #endif
>   #endif
> 
> or some such?

While this shouldn't hurt, I don't think it's necessary.