[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Changes in calendar/time-date.el
From: |
Lute Kamstra |
Subject: |
Re: Changes in calendar/time-date.el |
Date: |
Thu, 31 Mar 2005 14:58:48 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
Reiner Steib <address@hidden> writes:
> On Wed, Mar 30 2005, Katsumi Yamaoka wrote:
>
>> There's no ChangeLog for the recent changes of time-date.el and
>> I don't know who did it for what purpose,
>
> [ I'm adding emacs-devel. ]
> In Emacs, `time-date.el' is located in the calendar subdirectory.
> Probably Miles' script cannot fetch the ChangeLog automatically.
>
> I think this is the relevant entry:
>
> ,----[ lisp/ChangeLog ]
> | 2005-03-23 Lute Kamstra <address@hidden>
> | [...]
> | * calendar/time-date.el: Add comment on time value formats.
> | Don't require parse-time.
> | (with-decoded-time-value): New macro.
> | (encode-time-value): New function.
> | (time-to-seconds, time-less-p, time-subtract, time-add): Use them.
> | (days-to-time): Return a valid time value when arg is huge.
> | (time-since): Use time-subtract.
> | (time-to-number-of-days): Use time-to-seconds.
> `----
>
>> but at least the byte compiler complains to me about some missing
>> Lisp objects. What should we do for that?
>
> Probably we need to add (require 'parse-time) to nnimap.el,
> nnultimate.el and pop3.el.
I gather from this message that time-date's home is actually Gnus'
CVS? I wasn't aware of that. In Emacs' CVS it's in lisp/calendar and
not in lisp/gnus, so ChangeLog entries go to lisp/ChangeLog and not
lisp/gnus/ChangeLog. This should probably be dealt with manually when
synchronizing Emacs' CVS and Gnus' CVS.
I removed (require 'parse-time) from time-date because it uses just
parse-time-string, which is autoloaded. Do I understand correctly my
change uncovered some bugs in nnimap.el, nnultimate.el and pop3.el? I
already noticed (and fixed) this for message.el. I don't use
nnimap.el, nnultimate.el or pop3.el so I didn't catch those. I'm
sorry for that.
Lute.