[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix for release-critical bug in url-http.el
From: |
Klaus Straubinger |
Subject: |
Fix for release-critical bug in url-http.el |
Date: |
Mon, 3 Jan 2005 16:16:04 +0100 (CET) |
In admin/FOR-RELEASE a bug is described in url-http.el that is said to
come from url-http-parse-headers. However, I tracked this bug down to
a bad "(kill-buffer (current-buffer))" in the function
url-http-handle-authentication. The following fix cured the problem
completely for me, so I would suggest to implement it instead of the
suggested fix from the bug's original message which could not work
as far as I understand.
--- url-http.el.orig 2004-12-01 14:30:34.000000000 +0100
+++ url-http.el 2005-01-03 16:03:43.710185096 +0100
@@ -322,8 +322,8 @@
(let ((url-request-method url-http-method)
(url-request-data url-http-data)
(url-request-extra-headers url-http-extra-headers))
- (url-retrieve url url-callback-function url-callback-arguments))))
- (kill-buffer (current-buffer)))))
+ (url-retrieve url url-callback-function
+ url-callback-arguments)))))))
(defun url-http-parse-response ()
"Parse just the response code."
--- ChangeLog.orig 2004-12-14 14:25:16.000000000 +0100
+++ ChangeLog 2005-01-03 16:05:53.785410656 +0100
@@ -1,3 +1,8 @@
+2005-01-03 Klaus Straubinger <address@hidden>
+
+ * url-http.el (url-http-handle-authentication): Don't kill the
+ current buffer.
+
2004-12-11 Stefan Monnier <address@hidden>
* url-handlers.el: Don't `require' everything eagerly.
Regards
Klaus Straubinger
- Fix for release-critical bug in url-http.el,
Klaus Straubinger <=