[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: defconst in tpu-edt.el
From: |
Rob Riepel |
Subject: |
Re: defconst in tpu-edt.el |
Date: |
Mon, 29 Nov 2004 15:03:49 -0800 |
On Nov 14, 2004, at 10:50 AM, Luc Teirlinck wrote:
The patch below changes the two defconst's that produce compiler
warnings in tpu-edt to defvars. The defconsts for tpu-version,
tpu-emacs19-p and tpu-lucid-emacs19-p might be legitimate. I believe
that, in addition to the two defconst's changed in the patch, the
defconst's for tpu-help-keypad-map and tpu-help-text are dubious, but
I hope that the author can take a look at those two.
Sorry for the delay in replying to this. The day job is taking more
time than it should.
I agree with the reason for the patch and I also agree that
"(defconst tpu-help-keypad-map" and "(defconst tpu-help-text" should
be "(defvar tpu-help-keypad-map" and "(defvar tpu-help-text".
If someone with commit access would make these changes I would be
most grateful. Thanks.
===File ~/tpu-edt.el-diff===================================
*** tpu-edt.el 29 Feb 2004 17:58:53 -0600 1.36
--- tpu-edt.el 14 Nov 2004 09:55:29 -0600
***************
*** 1706,1714 ****
;;;
;;; Movement by word
;;;
! (defconst tpu-word-separator-list '()
"List of additional word separators.")
! (defconst tpu-skip-chars "^ \t"
"Characters to skip when moving by word.
Additional word separators are added to this string.")
--- 1706,1714 ----
;;;
;;; Movement by word
;;;
! (defvar tpu-word-separator-list '()
"List of additional word separators.")
! (defvar tpu-skip-chars "^ \t"
"Characters to skip when moving by word.
Additional word separators are added to this string.")
============================================================