emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs-unicode-2: w32_font_match


From: Jason Rumney
Subject: Re: Emacs-unicode-2: w32_font_match
Date: Tue, 02 Nov 2004 08:54:50 +0000
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (windows-nt)

KOBAYASHI Yasuhiro <address@hidden> writes:

> The attached patch use fast_string_match for comparing
> font names.

Thank you, I installed it.

-  return (fast_c_string_match_ignore_case (build_string (regex),
-                                           font_name_copy) >= 0);
+  return (fast_string_match_ignore_case (build_string (regex),
+                                         build_string (fontname)) >= 0);

Shouldn't that last line be "build_string (font_name_copy)) >= 0);"?

Otherwise you create font_name_copy, modify it, then never use it.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]