emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: how-many/count-matches for non-interactive use


From: Richard Stallman
Subject: Re: how-many/count-matches for non-interactive use
Date: Sat, 23 Oct 2004 14:49:05 -0400

The call to interactive-p in ibuf-ext.el is in ibuffer-kill-line.
Since it conditions the choice of whether to use call-interactively,
it is most surely wrong.  I think this is the right fix; would someone
who uses ibuf-ext.el please check it?


*** ibuf-ext.el 23 Oct 2004 10:00:10 -0400      1.39
--- ibuf-ext.el 23 Oct 2004 13:45:58 -0400      
***************
*** 645,660 ****
    (ibuffer-update nil t))
  
  ;;;###autoload
! (defun ibuffer-kill-line (&optional arg)
    "Kill the filter group at point.
  See also `ibuffer-kill-filter-group'."
!   (interactive "P")
    (ibuffer-aif (save-excursion
                 (ibuffer-forward-line 0)
                 (get-text-property (point) 'ibuffer-filter-group-name))
        (progn
        (ibuffer-kill-filter-group it))
!       (funcall (if (interactive-p) #'call-interactively #'funcall)
               #'kill-line arg)))
  
  (defun ibuffer-insert-filter-group-before (newgroup group)
--- 645,660 ----
    (ibuffer-update nil t))
  
  ;;;###autoload
! (defun ibuffer-kill-line (&optional arg interactive)
    "Kill the filter group at point.
  See also `ibuffer-kill-filter-group'."
!   (interactive "P\np")
    (ibuffer-aif (save-excursion
                 (ibuffer-forward-line 0)
                 (get-text-property (point) 'ibuffer-filter-group-name))
        (progn
        (ibuffer-kill-filter-group it))
!       (funcall (if interactive-p #'call-interactively #'funcall)
               #'kill-line arg)))
  
  (defun ibuffer-insert-filter-group-before (newgroup group)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]