[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: do-auto-fill bug?
From: |
David Kastrup |
Subject: |
Re: do-auto-fill bug? |
Date: |
06 Jul 2004 09:29:28 +0200 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
Stefan <address@hidden> writes:
> > I sent a bug report to the pretest-bug list toward the end of
> > May, however there is no response so far. Is no one being
> > troubled with the problem? The patch I included in the report
> > seems to have no problem so far, and I hope it will be applied.
>
> I've taken a quick look a while back but haven't had the time to come up
> with a good bugfix yet. Maybe your patch (improved to also prevent
> breaking in front of "[ \t]*$") is good enough,
I failed to followup on the following posting on emacs-pretest-bug.
Maybe one of the fixes is better than the other?
From: Richard Stallman <address@hidden>
To: David Kastrup <address@hidden>
CC: address@hidden
Subject: Re: auto-fill-mode and filling paragraphs differ
References: <address@hidden>
Message-Id: <address@hidden>
Date: Fri, 02 Apr 2004 01:01:12 -0500
I would interpret this as the last permissable column of content.
According to C-x =, column 70 is the column _after_ fsafd. If we now
say "ok, at this column, the end of line is legal", it would appear
that auto-fill-mode wraps one column too early. I think that typing a
space immediately at the end of line should _not_ wrap the preceding
word to the next line, but merely replace the typed space (instead of
the last space before that) with a newline.
I agree with you. Does this patch give correct results?
*** fill.el.~1.170.~ Fri Mar 26 12:04:37 2004
--- fill.el Thu Apr 1 23:12:54 2004
***************
*** 353,359 ****
;; Don't split a line if the rest would look like a new paragraph.
(unless use-hard-newlines
(save-excursion
! (skip-chars-forward " \t") (looking-at paragraph-start)))
(run-hook-with-args-until-success 'fill-nobreak-predicate)))))
;; Put `fill-find-break-point-function' property to charsets which
--- 353,364 ----
;; Don't split a line if the rest would look like a new paragraph.
(unless use-hard-newlines
(save-excursion
! (skip-chars-forward " \t")
! ;; If this break point is at the end of the line,
! ;; which can occur for auto-fill, don't consider the newline
! ;; which follows as a reason to return t.
! (and (not (eolp))
! (looking-at paragraph-start))))
(run-hook-with-args-until-success 'fill-nobreak-predicate)))))
;; Put `fill-find-break-point-function' property to charsets which
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum