[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: avoid duplicates in history
From: |
Dan Nicolaescu |
Subject: |
Re: avoid duplicates in history |
Date: |
Fri, 04 Jun 2004 14:27:17 -0700 |
Juri Linkov <address@hidden> writes:
> Dan Nicolaescu <address@hidden> writes:
> When you'll write the final patch, please don't forget to make this
> option customizable by adding it to cus-start.el somewhere near
> `history-length'.
Thanks, will do, I didn't know about that.
> And please consider the situation where your patch doesn't work.
> There is the following condition in `read_minibuf':
>
> /* Don't duplicate the most recent entry in the history. */
> && NILP (Fequal (histstring, Fcar (histval)))))
>
> which prevents removing all duplicate elements from the history
> with your patch.
>
> This condition is redundant when `history-delete-duplicates' is t.
I believe this is fine, that condition just avoids adding consecutive
identical entries, there's no need to do anything when that condition
is false.