[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: Updated patch for a Windows implementation of play-sound - 2
From: |
Ben Key |
Subject: |
RE: Updated patch for a Windows implementation of play-sound - 2 |
Date: |
Sat, 26 Oct 2002 00:47:57 -0400 |
> Oh and the "normal" #ifdef style used in Emacs is:
>
> #if FOO
> #else /* !FOO */
> #endif /* !FOO */
> or
> #if FOO
> #endif /* FOO */
I find this style of #ifdef blocks to be much too cryptic for my tastes.
What does /* !FOO */ and /* FOO */ mean anyway. I find that it is much
clearer if your comments for the #else and #endif portions state exactly
what #ifdef line they go to rather than some cryptic reference to what they
go to. This style causes much less confusion and is a great help when you
are not really reading the code in detail but are just skimming through
looking for the place where you need to make a change.
This is one of the few places where my coding style differs from the GNU
coding standards.
I would like to thank you for testing this patch on Linux. I have not yet
had a chance to do so myself. I still do not have my Linux machine up and
running completely. I am now trying to get Samba to work on it properly.