Re: Building emacs with and without X -- packaging question.

[Rob Browning]

Rob Browning <address@hidden> writes:

> I finally had time to work on this, and I think I've tracked it down.
> In cus-dep.el we have:
>
>                   (let ((expr (read (current-buffer))))
>                     (condition-case nil
>                         (progn
>                           (eval expr)
>                           (put (nth 1 expr) 'custom-autoloaded is-autoloaded)
>                           (put (nth 1 expr) 'custom-where name))
>                       (error nil))))
>
> Note that the condition-case ignores errors.

With RMS's help, I've tracked down and fixed the scroll-bar.el related
diff and one other so that fns-*.el is now the only significant
difference between X and no-X versions of emacs.

Two remaining questions:

  1) would it be better if cus-dep's code didn't hide the errors while
     eval'ing the defcustoms above?  i.e. should it at least print an
     error message (or perhaps even halt)?  That would have caught
     both the defcusom errors I found (I believe the only two).

  2) to fix the problem with gnus-art.el's
     gnus-article-x-face-command, I copy-pasted the code that
     initializes gnus-article-compface-xbm from gnus-ems.el.  Can
     anyone see a problem with that as a short-term solution?  (The
     diff is below.)

Thanks

--- 0/lisp/gnus/gnus-art.el     2002-03-22 11:03:55.000000000 -0600
+++ 1/lisp/gnus/gnus-art.el     2002-09-15 16:42:46.000000000 -0500
@@ -207,7 +207,8 @@
   (if (and (fboundp 'image-type-available-p)
           (image-type-available-p 'xbm))
       'gnus-article-display-xface
-    (if gnus-article-compface-xbm
+    (if (eq 0 (string-match "#define"
+                            (shell-command-to-string "uncompface -X")))
        "{ echo '/* Width=48, Height=48 */'; uncompface; } | display -"
       "{ echo '/* Width=48, Height=48 */'; uncompface; } | icontopbm | \
 display -"))

-- 
Rob Browning
rlb @defaultvalue.org, @linuxdevel.com, and @debian.org
Previously @cs.utexas.edu
GPG=1C58 8B2C FB5E 3F64 EA5C  64AE 78FE E5FE F0CB A0AD