emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog


From: Stefan Monnier
Subject: Re: [Emacs-diffs] Changes to emacs/lisp/ChangeLog
Date: Mon, 01 Apr 2002 10:05:53 -0500

> [ Redirected to emacs-devel. ]
> 
>    From: Richard Stallman <address@hidden>
>    Date: Sun, 31 Mar 2002 09:40:15 -0700 (MST)
> 
>    >     Richard, play-sound is not guaranteed to exist.
>    > 
>    > Yes, I saw that.
>    > 
>    >     So it is not safe to make play-sound-file unconditional (we can 
> remove
>    >     XEmacs comment though).
>    > 
>    > It seems safe to me.  If play-sound is not defined, play-sound-file
>    > will get an error trying to call it.  I think that is cleaner behavior
>    > than what happens if play-sound-file is not defined at all.
> 
> I think it would be much cleaner to:
> 
> - Fprovide (intern ("sound"), Qnil) in sound.c when `play-sound' is defined

Why would

        (featurep 'sound)

be any better than

        (fboundp 'play-sound)

??


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]