[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: address@hidden: blink-cursor improvement suggestion]
From: |
Kim F. Storm |
Subject: |
Re: address@hidden: blink-cursor improvement suggestion] |
Date: |
26 Feb 2002 12:02:03 +0100 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 |
address@hidden (Kim F. Storm) writes:
> Alternatively, it could "blink" between the hollow and normal cursor
> shapes. Then we don't need an extra face.
Below you'll find a patch which does this (when the block cursor is used).
What do you think?
Index: xterm.c
===================================================================
RCS file: /cvs/emacs/src/xterm.c,v
retrieving revision 1.707
diff -c -r1.707 xterm.c
*** xterm.c 23 Feb 2002 16:33:00 -0000 1.707
--- xterm.c 26 Feb 2002 10:59:31 -0000
***************
*** 11640,11647 ****
else
new_cursor_type = HOLLOW_BOX_CURSOR;
}
- else if (w->cursor_off_p)
- new_cursor_type = NO_CURSOR;
else
{
struct buffer *b = XBUFFER (w->buffer);
--- 11640,11645 ----
***************
*** 11651,11656 ****
--- 11649,11661 ----
else
new_cursor_type = x_specified_cursor_type (b->cursor_type,
&new_cursor_width);
+ if (w->cursor_off_p)
+ {
+ if (new_cursor_type == FILLED_BOX_CURSOR)
+ new_cursor_type = HOLLOW_BOX_CURSOR;
+ else
+ new_cursor_type = NO_CURSOR;
+ }
}
}
Index: w32term.c
===================================================================
RCS file: /cvs/emacs/src/w32term.c,v
retrieving revision 1.146
diff -c -r1.146 w32term.c
*** w32term.c 23 Feb 2002 16:28:28 -0000 1.146
--- w32term.c 26 Feb 2002 10:59:32 -0000
***************
*** 9759,9766 ****
else
new_cursor_type = HOLLOW_BOX_CURSOR;
}
- else if (w->cursor_off_p)
- new_cursor_type = NO_CURSOR;
else
{
struct buffer *b = XBUFFER (w->buffer);
--- 9759,9764 ----
***************
*** 9770,9775 ****
--- 9768,9780 ----
else
new_cursor_type = x_specified_cursor_type (b->cursor_type,
&new_cursor_width);
+ if (w->cursor_off_p)
+ {
+ if (new_cursor_type == FILLED_BOX_CURSOR)
+ new_cursor_type = HOLLOW_BOX_CURSOR;
+ else
+ new_cursor_type = NO_CURSOR;
+ }
}
}
--
Kim F. Storm <address@hidden> http://www.cua.dk
- address@hidden: blink-cursor improvement suggestion], Richard Stallman, 2002/02/24
- Re: address@hidden: blink-cursor improvement suggestion], Kim F. Storm, 2002/02/25
- Re: address@hidden: blink-cursor improvement suggestion], Jason Rumney, 2002/02/25
- Re: address@hidden: blink-cursor improvement suggestion], Richard Stallman, 2002/02/27
- Re: address@hidden: blink-cursor improvement suggestion], Kim F. Storm, 2002/02/27
- Re: address@hidden: blink-cursor improvement suggestion], Richard Stallman, 2002/02/27
- Re: address@hidden: blink-cursor improvement suggestion], Richard Stallman, 2002/02/26