bug#70432: closed (30.0.50; C-h for help not working with C-h k)

[GNU bug Tracking System]

Your message dated Sat, 20 Apr 2024 12:13:50 +0300
with message-id <8634rg9z1t.fsf@gnu.org>
and subject line Re: bug#70432: 30.0.50; C-h for help not working with C-h k
has caused the debbugs.gnu.org bug report #70432,
regarding 30.0.50; C-h for help not working with C-h k
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70432: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70432
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; C-h for help not working with C-h k
>
>
>
>
> Date: 
>
> Wed, 17 Apr 2024 09:36:04 +0200
>
>
>
>
> To reproduce
>
> 1. emacs -Q
> 2. C-h k C-x t
> 3. display says Press C-h for help
> 4. C-h
> => C-x t C-h is undefined
>
> In GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.4.0, NS
>  appkit-2487.50 Version 14.4.1 (Build 23E224)) of 2024-04-16 built on
>  Pro.fritz.box
> Repository revision: 1be21dd95388037cfb71474a1fbd2a7d3583a80a
> Repository branch: master
> Windowing system distributor 'Apple', version 10.3.2487
> System Description:  macOS 14.4.1
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#70432: 30.0.50; C-h for help not working with C-h k
>
>
>
>
> Date: 
>
> Sat, 20 Apr 2024 12:13:50 +0300
>
>
>
>
> > Cc: gerd.moellmann@gmail.com, dmitry@gutov.dev, 70432@debbugs.gnu.org
> > Date: Thu, 18 Apr 2024 17:19:06 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > From: Stefan Monnier <monnier@iro.umontreal.ca>
> > > Cc: Gerd Möllmann <gerd.moellmann@gmail.com>,  Dmitry
> > >  Gutov
> > >  <dmitry@gutov.dev>,  70432@debbugs.gnu.org
> > > Date: Thu, 18 Apr 2024 09:51:54 -0400
> > > 
> > > > Dmitry and Stefan, any better ideas?
> > > >
> > > > diff --git a/lisp/help.el b/lisp/help.el
> > > > index d4e39f0..e6117ec 100644
> > > > --- a/lisp/help.el
> > > > +++ b/lisp/help.el
> > > > @@ -1049,6 +1049,9 @@ help--read-key-sequence
> > > >    (let ((enable-disabled-menus-and-buttons t)
> > > >          (cursor-in-echo-area t)
> > > >          (side-event nil)
> > > > +        ;; Showing the list of key sequences makes no sense when they
> > > > +        ;; asked about a key sequence.
> > > > +        (echo-keystrokes-help nil)
> > > >          saved-yank-menu)
> > > >      (unwind-protect
> > > >          (let (last-modifiers key-list)
> > > 
> > > Loos OK to me, tho maybe it should be the other way around: we should
> > > bind it to non-nil around those places where we know it makes sense?
> > 
> > It's a user option, so I don't think that would be a good idea.
>
> I've now installed a fix for this on master, and I'm therefore closing
> this bug.
>
>
> --- End Message ---