bug#70256: closed ([PATCH] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.)

[GNU bug Tracking System]

Your message dated Mon, 15 Apr 2024 10:34:53 +0100
with message-id <87mspvynnm.fsf@cbaines.net>
and subject line Re: [bug#70256] [PATCH v3] gnu: signon-plugin-oauth2: Fix 
installing in a doubled prefix.
has caused the debbugs.gnu.org bug report #70256,
regarding [PATCH] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
70256: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70256
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix.
>
>
>
>
> Date: 
>
> Sun,  7 Apr 2024 17:07:30 +0530
>
>
>
>
> This commit fixes creating one more /gnu/store/ directory inside its
> own prefix, creating again the same prefix inside it and then
> installing in it.
>
> * gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
> <#:make-flags>: Remove argument.
> <#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.
>
> Change-Id: I10e973980228354c9943741dd480544bffca65b8
> ---
>  gnu/packages/qt.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 1440c6981c..19185c3f6a 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -5327,7 +5327,6 @@ (define-public signon-plugin-oauth2
>      (inputs (list signond))
>      (arguments
>       (list #:tests? #f                  ;no tests
> -           #:make-flags #~(list (string-append "INSTALL_ROOT=" #$output))
>             #:phases
>             #~(modify-phases %standard-phases
>                 (replace 'configure
> @@ -5337,7 +5336,9 @@ (define-public signon-plugin-oauth2
>                        ""))
>                     (invoke "qmake"
>                             (string-append "PREFIX=" #$output)
> -                           (string-append "LIBDIR=" #$output "/lib")))))))
> +                           (string-append "LIBDIR=" #$output "/lib")
> +                           (string-append "SIGNON_PLUGINS_DIR=" #$output
> +                                          "/lib")))))))
>      (synopsis "OAuth 2 plugin for signon")
>      (description
>       "This plugin for the Accounts-SSO SignOn daemon handles the OAuth
>
> base-commit: 188d18fc47f0d38edfe06e3e5834fa8587bd300b
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---

--- Begin Message --- Subject: Re: [bug#70256] [PATCH v3] gnu: signon-plugin-oauth2: Fix installing in a doubled prefix. Date: Mon, 15 Apr 2024 10:34:53 +0100 User-agent: mu4e 1.12.2; emacs 29.3

Sughosha via Guix-patches via <guix-patches@gnu.org> writes:

> This commit fixes creating one more /gnu/store/ directory inside its
> own prefix, creating again the same prefix inside it and then
> installing in it.
>
> * gnu/packages/qt.scm (signon-plugin-oauth2)[arguments]:
> <#:make-flags>: Remove argument.
> <#:phases>: In configure phase, add SIGNON_PLUGINS_DIR variable.
>
> Change-Id: Ie7694690c320a95fd9bcc02cb39cd64007f0e979
> ---
>  gnu/packages/qt.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Looks good to me, I've pushed this to master as
8a257582e3366b37ab7651198fc4c8912c520b37.

Chris

signature.asc
Description: PGP signature

--- End Message ---